feat: add new bank locations with sailing requirements #1670
Conversation
Add new bank locations for areas requiring sailing skill levels: - SUNBLEAK_ISLAND (requires sailing level 72) - DEEPFIN_POINT (requires sailing level 67) - DEEPFIN_MINE_MID (requires sailing level 67) - DEEPFIN_MINE_EAST (requires sailing level 68) Each location includes proper world point coordinates and member status checks integrated with the existing hasRequirements() method.
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
WalkthroughThis change introduces four new bank locations to the BankLocation enum: DEEPFIN_POINT, DEEPFIN_MINE_MID, DEEPFIN_MINE_EAST, and SUNBLEAK_ISLAND, each with their corresponding WorldPoint coordinates. All new locations are designated as members-only areas. The hasRequirements method is extended to define sailing level prerequisites for each new location: Sunbleak Island requires level 72, while the three Deepfin locations require level 67. Additionally, the TAL_TEKLAN enum entry is reordered within the list. 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/bank/enums/BankLocation.java`:
- Around line 275-277: The DEEPFIN_MINE_EAST case in the BankLocation enum has a
mismatch: the comment and PR require Sailing level 68 but the code calls
Rs2Player.getSkillRequirement(Skill.SAILING, 67, false); update that call to use
68 and align the inline comment to "Requires sailing level 68 + Bank to be made"
so both code and comment reflect level 68.
| case DEEPFIN_MINE_EAST: | ||
| // Requires sailing level 68 + Bank to be made | ||
| return Rs2Player.getSkillRequirement(Skill.SAILING, 67, false); |
There was a problem hiding this comment.
Level mismatch: comment says 68, code checks 67.
The comment states the requirement is sailing level 68, but the code checks for level 67. The PR objectives also indicate this location should require level 68.
Proposed fix
case DEEPFIN_MINE_EAST:
// Requires sailing level 68 + Bank to be made
- return Rs2Player.getSkillRequirement(Skill.SAILING, 67, false);
+ return Rs2Player.getSkillRequirement(Skill.SAILING, 68, false);📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| case DEEPFIN_MINE_EAST: | |
| // Requires sailing level 68 + Bank to be made | |
| return Rs2Player.getSkillRequirement(Skill.SAILING, 67, false); | |
| case DEEPFIN_MINE_EAST: | |
| // Requires sailing level 68 + Bank to be made | |
| return Rs2Player.getSkillRequirement(Skill.SAILING, 68, false); |
🤖 Prompt for AI Agents
In
`@runelite-client/src/main/java/net/runelite/client/plugins/microbot/util/bank/enums/BankLocation.java`
around lines 275 - 277, The DEEPFIN_MINE_EAST case in the BankLocation enum has
a mismatch: the comment and PR require Sailing level 68 but the code calls
Rs2Player.getSkillRequirement(Skill.SAILING, 67, false); update that call to use
68 and align the inline comment to "Requires sailing level 68 + Bank to be made"
so both code and comment reflect level 68.
My earlier commit contained a typo. The value has been reviewed and updated.
2 participants
Add new bank locations for areas requiring sailing skill levels:
Each location includes proper world point coordinates and member status checks integrated with the existing hasRequirements() method.